Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to rc9 #958

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Bump to rc9 #958

merged 1 commit into from
Mar 27, 2024

Conversation

benthecarman
Copy link
Collaborator

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Mar 27, 2024

Deploying mutiny-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: e737bd5
Status: ✅  Deploy successful!
Preview URL: https://740cd3ef.mutiny-web.pages.dev
Branch Preview URL: https://rc8.mutiny-web.pages.dev

View logs

@TonyGiorgio
Copy link
Collaborator

Screenshot 2024-03-27 at 11 41 24 AM

what happened to the recommendation events?

@TonyGiorgio
Copy link
Collaborator

Why does it say "Created at 13 hours ago" ? Is it not aware of it's actual creation date? That's the updated date.

@benthecarman
Copy link
Collaborator Author

It's the time of the event. We can't really get a date otherwise

@TonyGiorgio
Copy link
Collaborator

It's the time of the event. We can't really get a date otherwise

Should be "last updated at" then

Copy link
Collaborator

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the recommendation events on master, but not on this PR, so something broke.

@TonyGiorgio TonyGiorgio changed the title Bump to rc8 Bump to rc9 Mar 27, 2024
@benthecarman
Copy link
Collaborator Author

lol we did it at the same time

@TonyGiorgio
Copy link
Collaborator

Screenshot 2024-03-27 at 2 02 17 PM

Nope, try again

@TonyGiorgio
Copy link
Collaborator

either get you and paul to remove your recommendation and add it again with a signet tag, or change the mutiny-node code to consider this

@benthecarman
Copy link
Collaborator Author

either get you and paul to remove your recommendation and add it again with a signet tag, or change the mutiny-node code to consider this

Yeah would be better to have paul and I edit our recommendation

@futurepaul
Copy link
Collaborator

so just login on this pr and recommend it again?

@benthecarman
Copy link
Collaborator Author

so just login on this pr and recommend it again?

yeah, you probably need to comment out the code that checks if you already recommended

@TonyGiorgio
Copy link
Collaborator

Should there be code to "unrecommend" a mint?

@benthecarman
Copy link
Collaborator Author

Should there be code to "unrecommend" a mint?

probably, don't think we need to block release on it though

@futurepaul
Copy link
Collaborator

cool, I recommended

Screenshot 2024-03-27 at 2 19 20 PM

@benthecarman
Copy link
Collaborator Author

Same

now just shows these two on mainnet for me

image

Copy link
Collaborator

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@TonyGiorgio TonyGiorgio merged commit 7650c04 into master Mar 27, 2024
5 checks passed
@TonyGiorgio TonyGiorgio deleted the rc8 branch March 27, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants