Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LSP url from servers #1205

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Remove LSP url from servers #1205

merged 2 commits into from
Jun 11, 2024

Conversation

benthecarman
Copy link
Collaborator

First commit removes the LSP url from the servers page, this shouldn't be changed from here but from the admin page so we make sure we call the change_lsp function.

Second commit calls trim on all the lsp urls to help prevent issues

@benthecarman
Copy link
Collaborator Author

Would be good to make the settings form just call .trim on everything but not sure how to do that cc @futurepaul

@TonyGiorgio TonyGiorgio merged commit 77df9de into master Jun 11, 2024
5 checks passed
@TonyGiorgio TonyGiorgio deleted the rm-lsp-server branch June 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants