Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a French-language translation for Mutiny #1184

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

yaeloss
Copy link
Contributor

@yaeloss yaeloss commented Jun 5, 2024

After having seen the German version, I put together a French translation of Mutiny Wallet, sourced from the en.json file.

For syntax, I chose to keep the conjugations and commands informal to honor the style, flow, and general debauchery of the Mutiny Wallet project. This may be outputting for some (tu and ton instead of vous and votre), but I believe the more casual style will be more appealing and familial to users.

Future edits from French grammar nerds will correct me if I've erred in this assumption.

I toned down my own Canadian French in favor of international French diction for broader adoption.

Most direct French translations of key Bitcoin terms are sourced from established project translations. Otherwise, I kept the original phrasing from the code base (ie. on-chain, Lightning). In French, most Bitcoin literature has not adopted the translation of "éclair" in favor of the English "Lightning," so I kept that in the original language.

I didn't do anything with keys (sorry guys that's beyond my comprehension), and I used the latest en.json file as my base for this file.

Put together a French version of Mutiny Wallet.

For syntax, I chose to keep the conjugations and commands informal to keep with the style, flow, and general debauchery of the Mutiny Wallet project.
@TonyGiorgio TonyGiorgio requested a review from futurepaul June 5, 2024 15:10
@TonyGiorgio
Copy link
Collaborator

great, thank you! Should just be one last little thing to do and that's to add french to the drop down list. Instructions here: https://github.com/MutinyWallet/mutiny-web?tab=readme-ov-file#translating

Added French
@yaeloss
Copy link
Contributor Author

yaeloss commented Jun 5, 2024

Okay, should be completed.

@benthecarman
Copy link
Collaborator

looks like something is wrong with the formatting, if you run pnpm format it will fix

Added space after running pnpm format
@yaeloss
Copy link
Contributor Author

yaeloss commented Jun 6, 2024

Seems it was a problem with the languages file. pnpm format was run and apparently fixed.

@TonyGiorgio
Copy link
Collaborator

Thank you!

@TonyGiorgio TonyGiorgio merged commit 0da0dce into MutinyWallet:master Jun 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants