get rid of unified receive #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
requested changes
May 2, 2024
futurepaul
force-pushed
the
no-more-unified
branch
from
eb21126 to
465dd2a
Compare
Deploying mutiny-web with
|
| Latest commit: |
b0b1d1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6bb0adb9.mutiny-web.pages.dev |
| Branch Preview URL: | https://no-more-unified.mutiny-web.pages.dev |
|
This is incorrect. |
|
Also, we should allow someone to just hit continue for 0 amount on chain. There's no reason they need to do anything for it. |
futurepaul
force-pushed
the
no-more-unified
branch
from
bb54b63 to
b6bdd14
Compare
|
addressed @TonyGiorgio comments and also @benthecarman I think I fixed the flicker #1125 |
|
closes #1126 as well |
|
I also fix dust amount errors in my fedimint onchain mutiny-node PR, but good to have it in both. |
TonyGiorgio
approved these changes
May 8, 2024
|
Good idea, i think i had to get rid of that when we had the remember selection checkbox |
only do one at a time, address or invoice move method chooser to receive amount screen fix flicker on send / swap pages amountless on-chain, fix receive warnings fix unnecessary "Failed to conduct wallet operation" errors close receive method chooser automatically
futurepaul
force-pushed
the
no-more-unified
branch
from
26d81b2 to
b0b1d1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more bip21, just lightning and bitcoin address. need to test this out with ben's upcoming pr so we make sure we can handle all the potential scenarios