Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick a federation on setup #1035

Merged
merged 1 commit into from
Apr 12, 2024
Merged

pick a federation on setup #1035

merged 1 commit into from
Apr 12, 2024

Conversation

futurepaul
Copy link
Collaborator

Screenshot 2024-04-11 at 9 55 33 AM

@TonyGiorgio
Copy link
Collaborator

Amazing, I love it. I think the copy could improve, both here and in the setup. Been asked a few times what this means. I think we can explain it a bit better, something that focuses on what it provides the user, and something a little less scary than "use at your own risk" while still communicating that each is a new network. Hard to wrap it all up in a small package, could benefit from a "learn more" screen itself.

@futurepaul
Copy link
Collaborator Author

I think the copy could improve, both here and in the setup.

I'll take another pass at it. Really hard to explain without a wall of text but I'll try again. I can add a learn more explainer modal for the truly curious.

@futurepaul futurepaul force-pushed the federation-on-setup branch from e839166 to c1bb2ae Compare April 11, 2024 16:15
Copy link

cloudflare-workers-and-pages bot commented Apr 11, 2024

Deploying mutiny-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7db3cc3
Status: ✅  Deploy successful!
Preview URL: https://5544216b.mutiny-web.pages.dev
Branch Preview URL: https://federation-on-setup.mutiny-web.pages.dev

View logs

@futurepaul futurepaul force-pushed the federation-on-setup branch from c1bb2ae to bbe9034 Compare April 11, 2024 20:45
@futurepaul
Copy link
Collaborator Author

@TonyGiorgio updated with the text you provided

Copy link
Collaborator

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@benthecarman
Copy link
Collaborator

think this broke the playwright test

@futurepaul futurepaul force-pushed the federation-on-setup branch from bbe9034 to 7db3cc3 Compare April 12, 2024 16:08
@futurepaul
Copy link
Collaborator Author

think this broke the playwright test

it was the confirm button's fault

@futurepaul futurepaul merged commit 11e0b86 into master Apr 12, 2024
5 checks passed
@futurepaul futurepaul deleted the federation-on-setup branch April 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants