change constructor of OrnsteinUhlenbeckDiffusion #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose changing the parametrization of the constructor of
OrnsteinUhlenbeckDiffusion
. The rationale behind this is that we typically want to tune the speed of convergence by changing the reversion parameter while keeping the distribution at equilibrium unchanged. Also, I think we won't tune the mean parameter in most cases because it is not very important in diffusion models. I also added a short docstring to the constructor.