Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #605

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Update README.md #605

merged 9 commits into from
Aug 23, 2023

Conversation

vthg2themax
Copy link
Contributor

Create a section to help for new people building this project

Create a section to help for new people building this project
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Murmele
Copy link
Owner

Murmele commented Jul 29, 2023

Hi, there is already a how to build section, why do you need an extra one?

Co-authored-by: Murmele <[email protected]>
@vthg2themax
Copy link
Contributor Author

This just makes it easy to create a build.sh file to automatically let a new user who downloads the source to quickly create a new executable on Linux. Please let me know if that's not something you want, or if it should be put somewhere else.

@Bian-Sh
Copy link

Bian-Sh commented Jul 29, 2023 via email

@Murmele
Copy link
Owner

Murmele commented Jul 29, 2023

@vthg2themax Can you add a script to the pack folder and refering in the Readme to that script? So a user can directly download it and creating a package

Copy link
Contributor Author

@vthg2themax vthg2themax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let me know if you have other thoughts.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vthg2themax and others added 2 commits August 1, 2023 06:40
Co-authored-by: Murmele <[email protected]>
Co-authored-by: Murmele <[email protected]>
@vthg2themax
Copy link
Contributor Author

@Murmele I think your edits are wonderful. Thank you! Let me know if there's anything further that should be modified.

@vthg2themax
Copy link
Contributor Author

@Murmele This link appears to not work:
https://raw.githubusercontent.com/Murmele/Gittyup/master/pack/buildUbuntu.sh
Is that something that will be created later, or do I need to rename something?

@Murmele
Copy link
Owner

Murmele commented Aug 3, 2023

@Murmele This link appears to not work: https://raw.githubusercontent.com/Murmele/Gittyup/master/pack/buildUbuntu.sh Is that something that will be created later, or do I need to rename something?

@vthg2themax the link will work as soon it is merged, but you have to rename the shell script to buildUbuntu.sh ;)

pack/build.sh Outdated Show resolved Hide resolved
@vthg2themax
Copy link
Contributor Author

I renamed the file. Thank you for the reminder!

Copy link
Contributor Author

@vthg2themax vthg2themax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should do it

pack/Readme.md Outdated Show resolved Hide resolved
@Murmele Murmele merged commit 24f52d9 into Murmele:master Aug 23, 2023
11 checks passed
@vthg2themax vthg2themax deleted the patch-1 branch August 24, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants