Skip to content

Commit

Permalink
question: CommitList - correct variable to use?
Browse files Browse the repository at this point in the history
The lambda captures `model`, but in the code, `mModel` is used.  Either the capture is superfluous, or the usage is incorrect.
  • Loading branch information
mwerle committed Aug 29, 2023
1 parent 3e942ef commit 1d73792
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/ui/CommitList.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1186,6 +1186,7 @@ CommitList::CommitList(Index *index, QWidget *parent)
connect(model, &CommitModel::statusFinished, [this, model](bool visible) {
mRestoreSelection = true; // Reset to default
// Fake a selection notification if the diff is visible and selected.
// FIXME: Should we reference `model` or `this->mModel` here?
if (visible && selectionModel()->isSelected(mModel->index(0, 0)))
resetSelection();

Expand Down

0 comments on commit 1d73792

Please sign in to comment.