Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better head pics of kids, Hide UI , Option NonNude #19

Merged
merged 4 commits into from
Dec 28, 2022

Conversation

getsmartt
Copy link
Contributor

[NPCs] Added option to take NPC full body screen shots with default outfits.
[NPCsHead] Added some scripting to take better headshots of child NPCs.
[NPCsHead] [NPCs] Hide UI while taking screenshots.
[NPCsHead] [NPCs] Added code to make sure player is in 1stPerson View.

Fixed some typos in the AutoTest_NPCs_Config description
Copy link
Owner

@Muriel-Salvan Muriel-Salvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution! I love it. Those new features are really great :D

I think we should apply some minor changes before we can merge it. If you want me to take care of those changes, please tell me and I will do it.

.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Data/Source/Scripts/AutoTest_Suite_NPCs.psc Show resolved Hide resolved
ConsoleUtil.ExecuteCommand("tai")
ConsoleUtil.ExecuteCommand("tcai")
ConsoleUtil.ExecuteCommand("tgm")
; TODO enable UI
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a TODO anymore: you just implemented it :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, didn't clean up all the TODOs

endIf

if nonNudeNPC == "false"
newRef.RemoveAllItems()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can put the newRef.RemoveAllItems() directly in the previous if, without explicitely setting nonNudeNPC to false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

newRef.RemoveAllItems()
; TODO: Add option for clothes here

string nonNudeNPC = GetConfig("non_nude")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Love it.

Data/Source/Scripts/AutoTest_Suite_NPCs.psc Show resolved Hide resolved
; Print Screen
; TODO: grab PrintScreen key from Config
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So true. Thanks for the TODO :D

@Muriel-Salvan Muriel-Salvan linked an issue Nov 9, 2022 that may be closed by this pull request
@getsmartt
Copy link
Contributor Author

Feel free to make the changes, as you see fit. I have a couple of more features I am working on, but they may not be things you want to implement.

what I'm working on now;

  1. Rename Screenshots
    Eventually would like to do this directly from the script, but I'm pretty sure that this is going to require a DLL.
    Create a batch file to rename screenshots. (inprogress).
    Option that follows EasyNPC's 'mugshot' naming convention.
    Option that lets user define name [i.e. {NPCName}({NPCFormid})-{NPCMod}.png.
    These require ( at least in my current implementation) an additional 'field' in the json file...
    i.e. skyrim.esp/formID of NPC/bejinwives.esp
  2. Xedit scripts to grab NPC's (and locations) to test from specific mods. (inprogress).
    I used your script from ModVaskr, and modified it to select only the NPCs from the scripts selected in Xedit, it also saves a
    .json file directly. And implements my additional field referenced above. Will make one that does locations only as well.
  3. Let user choose location where screenshots are taken. vs them always being taken in the 'test cell'
  4. Use alternate screenshot methods (maybe) ENB and Steam Overlay options? Not sure about this but from what I've seen screen shots taken in game through the Skyrim screenshot do not always represent what it looks like on screen with ENB active.
  5. Utilize Dark Face Issue Reporter batch files to create test files. for NPCs
  6. An Armor test scenario, implementing the basic features... an xedit script to grab armors from whatever mod you want, summon NPC(s) in that armor and grab screen shots.

@Muriel-Salvan Muriel-Salvan merged commit 5548ace into Muriel-Salvan:master Dec 28, 2022
@Muriel-Salvan
Copy link
Owner

@getsmartt I just merged and released v1.2.0 on NexusMods with your changes :D Thanks a lot for your help, it is really appreciated. I also credited you in the README.

Sorry for the time it took on my end, but I wanted to test it thoroughly before releasing, and I had to update all my versions (it was long time since I played Skyrim - now I'm back on it :D ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Children don't display correctly in the NPCsHead test
2 participants