Add support for the custom_info object as OrderRequest argument #9
Conversation
|
Hi @DaanDeSmedt Thanks for submitting this contribution. We just assigned two developers as reviewers of this PR. |
|
@Daniel-MultiSafepay , Thanks for the heads-up. 👍 I've fixed the Code sniffer / Check coding conventions on my added code. I suppose some extra pair of eyes on the failing unit tests would be welcome, since these failing unit tests don't seem related to my additions(?). Have a great day! |
There was a problem hiding this comment.
Hi @DaanDeSmedt
After reviewing your code we can confirm that the changes are working as intended. There is only an issue with the code sniffer. If you could solve that issue we can merge the PR.
Regarding the tests failing, this is due to not having certain payment methods available on your test account. I've added an internal ticket to resolve this issue.
So for the failing tests, you don't have to do anything at this moment
| 'custom_3' => $this->getCustom3(), | ||
| ]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Expected 1 newline at end of file; 0 found
There was a problem hiding this comment.
@Mike-MultiSafepay , great feedback, thanks! Just pushed a fix for the code sniffer issue mentioned.
|
Thanks for this contribution @DaanDeSmedt. !! We just merged the PR into the master branch. All tests are passing, but some of them fail here, on GitHub, because the API Key set as a secret of this repository is not properly configured. I will check and fix that in the next couple of days. We will be happy to send you a present as proof of our appreciation for your contribution. Could you share with us your email address by sending us an email to [email protected] with a reference to this PR; so we can stay in contact and get your address, and details required? Thanks again. |
|
You're welcome, and thank you for merging the PR into the master branch. I appreciate your offer of a present as a token of appreciation for my contribution. Great day! |
Description
As per the documentation provided by MultiSafepay (https://docs.multisafepay.com/reference/createorder), the
custom_infoobject allows the inclusion of extra order-related detail fields.I've sourced the php-sdk but have not come across any indication of this feature.
To address this gap, I've taken the liberty in creating this PR to suggest some code changes.
Which addresses an approach for reported Support custom_info when creating a payment page/link #8
Type of change
Added Unit tests
Added basis unit tests to check correct implementation.
testRequestOrderRequestWithCustomInfoon the test classOrderRequestTest.phpCustomInfoTestto validate setting & retrieving custom info based on thecustom_1,custom_2&custom_3approach described in the docs.