Provide more context when starting PostgreSQL #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a connection to the PostgreSQL database cannot be established, operators are instructed to wait indefinitely. They need to exercise their own judgement to determine that an unrecoverable error may have occurred, and they must then formulate their own plan to diagnose the problem. This change introduces a suggestion about the possibility of failure and some contextual information that will assist in debugging. It also causes the script to fail immediately for truly exceptional circumstances such as the absence of required modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a connection to the PostgreSQL database cannot be
established, operators are instructed to wait indefinitely. They need to
exercise their own judgement to determine that an unrecoverable error
may have occurred, and they must then formulate their own plan to
diagnose the problem. This change introduces a suggestion about the
possibility of failure and some contextual information that will assist
in debugging. It also causes the script to fail immediately for truly
exceptional circumstances such as the absence of required modules.
I've also submitted this patch to the "template" project from which the script originated: cookiecutter/cookiecutter-django#3782
As noted there, I've arbitrarily chosen 30 seconds as the duration to wait before suggesting that something may not be working. Does that seem like an appropriate value to folks more familiar with this process?