Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve search params when navigating within the viewer #985

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Dec 16, 2024

Closes #933

Example URL: https://deploy-preview-985.muckcloud.com/documents/20006908-lawsuit-document-dkt-1-68-ex-j/?q=apple&mode=search&embed=1&title=0

Clicking links in search or the mode tabs should keep you in the embed viewer and preserve params like title=0.

@eyeseast eyeseast requested a review from allanlasser December 16, 2024 20:38
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 3411694
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/67608fd94e91df00088c7f34
😎 Deploy Preview https://deploy-preview-985.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.8% 7674 / 24127
🔵 Statements 31.8% 7674 / 24127
🔵 Functions 47.74% 339 / 710
🔵 Branches 75.71% 1113 / 1470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/common/Tab.svelte 100% 66.66% 100% 100%
src/lib/components/viewer/ReadingToolbar.svelte 0% 0% 0% 0% 1-163
src/lib/components/viewer/Search.svelte 0% 0% 0% 0% 1-90
src/lib/utils/navigation.ts 100% 66.66% 100% 100%
src/lib/utils/tests/navigation.test.ts 100% 100% 100% 100%
Generated in workflow #525 for commit 3411694 by the Vitest Coverage Report Action

Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Love the new util.

@eyeseast eyeseast merged commit ac8fef7 into main Dec 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed parameters should persist when navigating
2 participants