Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted fix for private PDF 403 error #974

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

allanlasser
Copy link
Member

Fixes #836

When we're fetching a private asset and we get a 403 response, try refetching the private asset URL and trying again (up to a maximum of 5 tries).

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 41ebce7
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/675b62a81f66b8000738ba90
😎 Deploy Preview https://deploy-preview-974.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🔴 down 22 from production)
Accessibility: 87 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.7% 7638 / 24093
🔵 Statements 31.7% 7638 / 24093
🔵 Functions 47.74% 338 / 708
🔵 Branches 75.73% 1108 / 1463
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/viewer/ViewerContext.svelte 0% 0% 0% 0% 1-216
Generated in workflow #511 for commit 41ebce7 by the Vitest Coverage Report Action

@allanlasser allanlasser requested a review from eyeseast December 12, 2024 22:28
@allanlasser allanlasser merged commit c489fe6 into main Dec 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected server response (403) while retrieving PDF from S3
2 participants