Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redaction box drawing logic #970

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix redaction box drawing logic #970

merged 2 commits into from
Dec 12, 2024

Conversation

allanlasser
Copy link
Member

Fixes #969

As a bonus, slight improvement to annotation box drawing logic, too!

Doesn't consolidate the logic, since it depends on global variables to work correctly. Could be revisited in the future.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit f416051
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/675b509c13c3380008b47239
😎 Deploy Preview https://deploy-preview-970.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 24 from production)
Accessibility: 87 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.7% 7638 / 24093
🔵 Statements 31.7% 7638 / 24093
🔵 Functions 47.74% 338 / 708
🔵 Branches 75.73% 1108 / 1463
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/viewer/AnnotationLayer.svelte 0% 0% 0% 0% 1-280
src/lib/components/viewer/RedactionLayer.svelte 0% 0% 0% 0% 1-135
Generated in workflow #505 for commit f416051 by the Vitest Coverage Report Action

@allanlasser allanlasser merged commit 9a61b20 into main Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot make a redaction smaller while drawing it
2 participants