Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to customize DocumentListItem #954

Merged
merged 20 commits into from
Dec 10, 2024
Merged

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Dec 5, 2024

So many people have their own opinions for what belongs in a document search result. Instead of a one-size fits all solution, this allows for users to override a set of opinionated defaults.

VisibleFields storybook

Screenshot 2024-12-08 at 6 37 07 PM

Resolves #881, resolves #834

  • Updates styling for document list items
  • Splits out anchor links within document list item
  • Updates apperance and generic logic of KV component, so it can adapt to being a link
  • Uses StorageManager to remember a user's VisibleFields preferences.
  • Add a dropdown menu to DocumentBrowser's top toolbar for users to toggle fields.

To-Do

  • i18n
  • add search links to data
  • handle tag data

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit a99d618
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/67586ba83570910008b9cb87
😎 Deploy Preview https://deploy-preview-954.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 33 from production)
Accessibility: 87 (🟢 up 2 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.79% 7634 / 24010
🔵 Statements 31.79% 7634 / 24010
🔵 Functions 47.74% 338 / 708
🔵 Branches 75.73% 1108 / 1463
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/common/KV.svelte 100% 100% 100% 100%
src/lib/components/common/Menu.svelte 100% 100% 100% 100%
src/lib/components/documents/DocumentListItem.svelte 58.26% 78.7% 53.5% 58.26% 70-74, 96-100, 114-120, 123-125, 128-129, 133-134, 169-173, 185-187, 190-192, 195-196, 200-201, 251-264, 285-321, 325-326, 364-369, 382-388, 392-394, 421-422, 429, 433-435, 463-467, 478, 482-483, 515-521, 535-579, 582-585, 588-590, 594-595, 621-622, 625, 631-632, 637-641, 645-648, 654-679, 682-688, 691-697, 701-702, 720-776, 790, 802-806, 819-844, 847-853, 856-862, 866-867, 904, 911-916, 919-921, 924-925, 955, 967-971, 984-1009, 1012-1018, 1021-1027, 1031-1032, 1095-1121, 1168-1275, 1278-1282, 1285-1288, 1338-1339, 1349, 1353-1354, 1358-1381, 1385-1391, 1395-1396, 1447-1448, 1451-1453, 1456-1457, 1460-1462
src/lib/components/documents/ResultsList.svelte 100% 26.66% 100% 100%
src/lib/components/documents/Thumbnail.svelte 100% 75% 100% 100%
src/lib/components/documents/VisibleFields.svelte 5.84% 100% 0% 5.84% 57-69, 72-105, 108-188, 191-279, 282-435, 438-471, 474-518, 521-554, 557-846, 879-970, 974-983, 986-987, 990-992, 995-996, 999-1001
src/lib/components/layouts/DocumentBrowser.svelte 0% 0% 0% 0% 1-2536
src/lib/components/layouts/DocumentListToolbar.svelte 0% 0% 0% 0% 1-42
src/lib/components/sidebar/SidebarItem.svelte 100% 100% 100% 100%
src/lib/components/viewer/AnnotationLayer.svelte 0% 0% 0% 0% 1-280
src/lib/components/viewer/NoteTab.svelte 100% 100% 100% 100%
Generated in workflow #486 for commit a99d618 by the Vitest Coverage Report Action

@allanlasser allanlasser marked this pull request as ready for review December 6, 2024 22:55
@allanlasser allanlasser requested a review from eyeseast December 6, 2024 22:55
@allanlasser allanlasser merged commit 206f131 into main Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Compact" and "Expanded" DocumentListItem views Improve data display on document list items
2 participants