Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect page and note endpoints to embed versions #919

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Dec 3, 2024

  • Redirect old note permalinks to embeds
  • Redirect page endpoints to embed

This should handle any existing embeds that didn't include the embed.documentcloud.org or ?embed=1 in the URL.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 5147167
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/674f4a22c715c0000849a314
😎 Deploy Preview https://deploy-preview-919.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 31 from production)
Accessibility: 86 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.8% 6724 / 21826
🔵 Statements 30.8% 6724 / 21826
🔵 Functions 49.46% 275 / 556
🔵 Branches 75.03% 1013 / 1350
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/routes/(app)/documents/[id]/annotations/[note_id]/+page.ts 0% 0% 0% 0% 1
src/routes/(app)/documents/[id]/pages/[page]/+page.ts 0% 0% 0% 0% 1
Generated in workflow #420 for commit 5147167 by the Vitest Coverage Report Action

@eyeseast eyeseast merged commit 39e3318 into main Dec 3, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants