Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show search results in new viewer mode #912

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Dec 2, 2024

Fixes #909

  • Shows search results in a new viewer mode, search, with a link to view the result back in document mode.
  • Results are loaded upon query changes.
  • Search calls are made in the browser.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 2ed556a
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/674f79fb234e6400086ea4dd
😎 Deploy Preview https://deploy-preview-912.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 23 (🔴 down 32 from production)
Accessibility: 86 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.74% 6727 / 21877
🔵 Statements 30.74% 6727 / 21877
🔵 Functions 49.28% 275 / 558
🔵 Branches 74.98% 1013 / 1351
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/api/documents.ts 90.95% 89.09% 96.96% 90.95% 89-108, 179-181, 186-187, 204-210, 214-215, 514-516
src/lib/api/types.d.ts 0% 0% 0% 0% 1-3
src/lib/components/common/Highlight.svelte 100% 100% 100% 100%
src/lib/components/forms/Search.svelte 0% 0% 0% 0% 1-82
src/lib/components/viewer/Page.svelte 0% 0% 0% 0% 1-644
src/lib/components/viewer/ReadingToolbar.svelte 0% 0% 0% 0% 1-150
src/lib/components/viewer/Search.svelte 0% 0% 0% 0% 1-70
src/lib/components/viewer/Viewer.svelte 0% 0% 0% 0% 1-111
src/lib/components/viewer/ViewerContext.svelte 0% 0% 0% 0% 1-198
src/lib/load/document.ts 0% 0% 0% 0% 1-53
Generated in workflow #424 for commit 2ed556a by the Vitest Coverage Report Action

@allanlasser allanlasser requested a review from eyeseast December 2, 2024 22:56
@allanlasser allanlasser marked this pull request as ready for review December 2, 2024 22:56
Copy link
Collaborator

@eyeseast eyeseast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the tooltip around search, now that we have this.

@allanlasser allanlasser merged commit 08fcc8c into main Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Search mode to Viewer
2 participants