You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a complex interaction achieved with little DOM trickery.
First, it sets pointer-events: none on the highlight element to allow users to select the text that's been highlighted.
Then, it listens for clicks on the page and compares the click coordinates with the coordinates of highlights on the page. If the click is within the highlight's bounds, it will dispatch a click on the highlight to open the note.
As a side-effect, we can now support overlapping highlights! However, we only support a single note in our $currentNote store, so for now the last highlight that calls click will be the note that appears. I've captured this as #907. (One issue closed, another opened; so it goes.)
1 paths audited Performance: 26 (🔴 down 32 from production) Accessibility: 86 (🟢 up 1 from production) Best Practices: 83 (🔴 down 9 from production) SEO: 82 (no change from production) PWA: - View the detailed breakdown and full score reports
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #778
This is a complex interaction achieved with little DOM trickery.
First, it sets
pointer-events: noneon the highlight element to allow users to select the text that's been highlighted.Then, it listens for clicks on the page and compares the click coordinates with the coordinates of highlights on the page. If the click is within the highlight's bounds, it will dispatch a click on the highlight to open the note.
As a side-effect, we can now support overlapping highlights! However, we only support a single note in our
$currentNotestore, so for now the last highlight that callsclickwill be the note that appears. I've captured this as #907. (One issue closed, another opened; so it goes.)