Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getApiResponse on infinite scrolls, too #880

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

eyeseast
Copy link
Collaborator

Closes #829

This aligns our infinite scroll handling with other places we hit the API and lets us show an error message when something fails.

Copy link

github-actions bot commented Nov 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.81% 6738 / 21866
🔵 Statements 30.81% 6738 / 21866
🔵 Functions 49.72% 274 / 551
🔵 Branches 75.52% 1012 / 1340
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/addons/History.svelte 0% 0% 0% 0% 1-78
src/lib/components/addons/Scheduled.svelte 0% 0% 0% 0% 1-81
src/lib/components/documents/ResultsList.svelte 100% 28.57% 100% 100%
Generated in workflow #779 for commit 31f55fb by the Vitest Coverage Report Action

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 31f55fb
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/674491de56bf1800080bfefa
😎 Deploy Preview https://deploy-preview-880.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49
Accessibility: 85
Best Practices: 92
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyeseast eyeseast requested a review from allanlasser November 25, 2024 13:53
src/lib/components/addons/History.svelte Outdated Show resolved Hide resolved
src/lib/components/addons/History.svelte Outdated Show resolved Hide resolved
src/lib/components/addons/Scheduled.svelte Outdated Show resolved Hide resolved
src/lib/components/addons/Scheduled.svelte Outdated Show resolved Hide resolved
@allanlasser allanlasser linked an issue Nov 25, 2024 that may be closed by this pull request
@eyeseast eyeseast merged commit 112b4cd into sveltekit Nov 25, 2024
10 of 11 checks passed
Copy link

sentry-io bot commented Dec 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of null (reading 'title') /(app)/documents View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle infinite scroll load failures
2 participants