Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a slot to show search tips #877

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add a slot to show search tips #877

merged 2 commits into from
Nov 25, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Nov 22, 2024

Closes #843

Screenshot 2024-11-22 at 6 11 41 PM

@eyeseast eyeseast requested a review from allanlasser November 22, 2024 23:12
Copy link

github-actions bot commented Nov 22, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.79% 6727 / 21843
🔵 Statements 30.79% 6727 / 21843
🔵 Functions 49.72% 274 / 551
🔵 Branches 75.65% 1013 / 1339
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/forms/Search.svelte 0% 0% 0% 0% 1-77
src/lib/components/layouts/DocumentBrowser.svelte 0% 0% 0% 0% 1-2748
Generated in workflow #778 for commit 1b0a420 by the Vitest Coverage Report Action

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 1b0a420
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/67448e82b497b600084cbd22
😎 Deploy Preview https://deploy-preview-877.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 55
Accessibility: 85
Best Practices: 92
SEO: 82
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyeseast eyeseast merged commit 8208179 into sveltekit Nov 25, 2024
10 of 11 checks passed
Copy link

sentry-io bot commented Dec 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Right-hand side of 'instanceof' is not an object /embed/documents/[id]-[slug] View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants