Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent layout actions #876

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Consistent layout actions #876

merged 13 commits into from
Nov 25, 2024

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Nov 22, 2024

Closes #869
Closes #870

This updates our sidebar navigation to be more consistent between pages. Rather than reflect the navigation and actions available on the "resource" defined by the route, they instead reflect a more "global" application organization.

In the process, we've forfeit the "Add-Ons Navigation" with category-based filtering. This could be reintroduced as part of the search toolbar. Add-Ons are low use so this is not considered a problematic loss.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 086358e
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6744d5918a74d1000892098e
😎 Deploy Preview https://deploy-preview-876.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62
Accessibility: 85
Best Practices: 92
SEO: 82
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.98% 6738 / 21746
🔵 Statements 30.98% 6738 / 21746
🔵 Functions 49.63% 274 / 552
🔵 Branches 75.46% 1012 / 1341
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/documents/DocumentListItem.svelte 54.46% 75.82% 51.25% 54.46% 60-64, 73-166, 184-193, 213-223, 229-230, 260, 274-282, 300-325, 328-334, 337-343, 347-348, 383, 390-392, 395-397, 400-401, 431-432, 440-461, 464-466, 469-470, 474-475, 510-514, 526-528, 531-533, 536-537, 541-542, 574-575, 582-584, 588-590, 617-618, 625, 629-631, 647-698, 739-740, 752-753, 756, 786-787, 792-834, 882-885, 899-1044, 1047-1056, 1059-1068, 1125-1126, 1129-1130, 1136-1137, 1147, 1151, 1155-1188, 1192-1203, 1207-1208, 1296-1297, 1300-1302
src/lib/components/documents/Header.svelte 0% 0% 0% 0% 1-407
src/lib/components/layouts/AddOnBrowser.svelte 0% 0% 0% 0% 1-153
src/lib/components/layouts/AddOnLayout.svelte 0% 0% 0% 0% 1-269
src/lib/components/layouts/DocumentBrowser.svelte 0% 0% 0% 0% 1-2748
src/lib/components/layouts/DocumentLayout.svelte 0% 0% 0% 0% 1-66
src/lib/components/layouts/Project.svelte 0% 0% 0% 0% 1-57
src/lib/components/layouts/Sidebar.svelte 0% 0% 0% 0% 1-85
src/lib/components/navigation/OrgMenu.svelte 0% 0% 0% 0% 1-200
src/lib/components/projects/Collaborators.svelte 0% 0% 0% 0% 1-192
src/lib/components/projects/ProjectHeader.svelte 0% 0% 0% 0% 1-676
src/lib/components/sidebar/ProjectActions.svelte 0% 0% 0% 0% 1-74
src/lib/components/sidebar/Projects.svelte 0% 0% 0% 0% 1-77
src/lib/components/sidebar/SidebarGroup.svelte 0% 0% 0% 0% 1-64
src/lib/components/sidebar/SidebarItem.svelte 100% 100% 100% 100%
src/lib/components/sidebar/UploadButton.svelte 0% 0% 0% 0% 1-37
src/routes/(app)/+layout.ts 0% 0% 0% 0% 1
src/routes/(app)/documents/+layout.ts 0% 0% 0% 0% 1
src/routes/(app)/documents/+page.svelte 0% 0% 0% 0% 1-37
src/routes/(app)/documents/+page.ts 0% 0% 0% 0% 1
src/routes/(app)/documents/[id]-[slug]/+page.svelte 0% 0% 0% 0% 1-65
src/routes/(app)/documents/[id]-[slug]/+page.ts 0% 0% 0% 0% 1
src/routes/(app)/projects/+page.svelte 0% 0% 0% 0% 1-106
src/routes/(app)/projects/[id]-[slug]/+page.svelte 0% 0% 0% 0% 1-38
src/routes/(app)/projects/[id]-[slug]/+page.ts 0% 0% 0% 0% 1
src/routes/(app)/upload/+page.svelte 0% 0% 0% 0% 1-28
src/routes/(app)/upload/+page.ts 0% 0% 0% 0% 1
Generated in workflow #788 for commit 086358e by the Vitest Coverage Report Action

@allanlasser allanlasser marked this pull request as ready for review November 25, 2024 16:58
@allanlasser allanlasser merged commit 9626b25 into sveltekit Nov 25, 2024
10 of 11 checks passed
@allanlasser allanlasser deleted the allanlasser/issue869 branch November 26, 2024 13:53
Copy link

sentry-io bot commented Dec 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch /(app)/documents View Issue
  • ‼️ ReferenceError: Can't find variable: ResizeObserver /(app)/documents View Issue
  • ‼️ TypeError: Failed to fetch /(app)/documents View Issue
  • ‼️ TypeError: Failed to fetch /(app)/documents View Issue
  • ‼️ TypeError: Load failed /documents/25444991-the-substance-read-the-scre... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust layout of Add-Ons Dispatch page Consistent actions between document and project layouts
2 participants