Standardize on 'en', not 'en-US' as a language code, but register both #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyeseast
requested review from
mitchelljkotler,
allanlasser and
duckduckgrayduck
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }); | ||
|
|
||
| // handle two-part locales | ||
| register("en-US", () => import("@/langs/json/en.json")); | ||
| register("en-GB", () => import("@/langs/json/en.json")); |
There was a problem hiding this comment.
Do we need to handle other two part locales? Spanish is spoken in a lot of countries.
There was a problem hiding this comment.
I'm not sure these are strictly necessary. I think part of the issue was that we were defaulting (in hooks.server.ts) to en-US and that wasn't registered.
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
allanlasser
approved these changes
Nov 21, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve #818
My browser sets the
accept-languageheader andwindow.navigator.languagetoen-US, but we weren't registering that as a locale, onlyen. So this adds that registration and also standardizes our own setting toen.