-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix viewer search and consolidate search routing, too #862
Conversation
Coverage Report
File Coverage
|
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need query
and getQuery
in ViewerContext
? Right now they're only used by Text
and ReaderToolbar
and seem like they could be replaced by the utility.
We probably don't. I'll take them out. |
Closes #846 and consolidates routing logic around search.
For PDF pages, we're now getting the search query directly from the URL, instead of props, and reacting to URL changes.