Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a help link to legacy DC #845

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add a help link to legacy DC #845

merged 2 commits into from
Nov 19, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Nov 19, 2024

Open to suggestions for a different icon or text here.

This is the last piece of #809

@eyeseast eyeseast requested a review from allanlasser November 19, 2024 02:12
Copy link

github-actions bot commented Nov 19, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.83% 6675 / 21645
🔵 Statements 30.83% 6675 / 21645
🔵 Functions 49.63% 273 / 550
🔵 Branches 75.43% 1007 / 1335
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/navigation/HelpMenu.svelte 0% 0% 0% 0% 1-92
Generated in workflow #744 for commit 753b722 by the Vitest Coverage Report Action

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 753b722
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/673ca6968ce07d000867089f
😎 Deploy Preview https://deploy-preview-845.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57
Accessibility: 85
Best Practices: 92
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM—just need to put the icon the start slot for alignment with other menu items.

src/lib/components/navigation/HelpMenu.svelte Outdated Show resolved Hide resolved
Co-authored-by: Allan Lasser <[email protected]>
@eyeseast eyeseast merged commit 19bbb31 into sveltekit Nov 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants