-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sveltekit error handling #705
Conversation
…d into sveltekit-error-handling
…d into sveltekit-error-handling
…s and made tests pass
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial guidance on generic types before you go further on retyping API calls. Overall makes a ton of sense.
Co-authored-by: Allan Lasser <[email protected]>
…d into sveltekit-error-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught one minor issue. And a question: are +error.svelte
pages coming later?
#502
This wraps API responses in a new type and abstracts handling responses from the API. It uses typescript generics to pass through the types we need, for both data and errors.