Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for SvelteKit PRs #513

Merged
merged 5 commits into from
Apr 16, 2024
Merged

CI for SvelteKit PRs #513

merged 5 commits into from
Apr 16, 2024

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Apr 16, 2024

This improves reporting on any SvelteKit PRs by:

  • Limiting Storybook to only SvelteKit directories, hopefully allowing Chromatic to successfully build and report changes.
  • Limiting Vitest to only SvelteKit directories, to provide more helpful feedback on PR coverage changes.
  • Limiting check to only check SvelteKit directories and related files, to flag any type errors during the PR process.

When I say SvelteKit directories, I mean src/lib and src/routes.

Check is currently failing since we have a number of unaddressed type and a11y issues. Those can be fixed in a follow-up task, but having the failing check will be a good reminder that they need to be fixed.

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 4d35843
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/661e9bec09e099000815e11d
😎 Deploy Preview https://deploy-preview-513.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 16.43% 841 / 5116
🔵 Statements 16.43% 841 / 5116
🔵 Functions 13.66% 19 / 139
🔵 Branches 26.4% 33 / 125
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/routes/stories/project-embed.stories.svelte 0% 0% 0% 0% 1-30
Generated in workflow #3

@allanlasser allanlasser merged commit f0fa736 into sveltekit Apr 16, 2024
9 of 10 checks passed
@allanlasser allanlasser deleted the sveltekit-ci branch April 24, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant