Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SvelteKit] Global Nav #508

Merged
merged 11 commits into from
Apr 17, 2024
Merged

[SvelteKit] Global Nav #508

merged 11 commits into from
Apr 17, 2024

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Apr 11, 2024

  • Adds breadcrumbs
  • Adds language menu
  • Adds help menu

The org menu is complex enough that I'm adding it on a separate branch. I wanted to land these relatively simple menus and interactions before continuing on add-ons and projects.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 37bfb69
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/66200f9089da3c00089f1812
😎 Deploy Preview https://deploy-preview-508.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allanlasser allanlasser force-pushed the sveltekit-navigation branch 4 times, most recently from 37c0501 to 63628de Compare April 12, 2024 21:03
@allanlasser allanlasser marked this pull request as ready for review April 12, 2024 21:07
@allanlasser allanlasser force-pushed the sveltekit-navigation branch from 10dcb60 to d91ebb2 Compare April 16, 2024 16:33
Copy link

github-actions bot commented Apr 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 34.73% 2196 / 6322
🔵 Statements 34.73% 2196 / 6322
🔵 Functions 23.18% 32 / 138
🔵 Branches 40.6% 67 / 165
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/components/MainLayout.svelte 0% 0% 0% 0% 1-250
src/lib/components/navigation/Breadcrumbs.svelte 100% 100% 100% 100%
src/lib/components/navigation/HelpMenu.svelte 0% 0% 0% 0% 1-58
src/lib/components/navigation/LanguageMenu.svelte 0% 0% 0% 0% 1-60
src/lib/utils/index.ts 100% 100% 100% 100%
src/lib/utils/navigation.ts 100% 100% 100% 100%
src/routes/+layout.ts 0% 0% 0% 0% 1-28
src/routes/app/+layout.svelte 0% 0% 0% 0% 1-41
src/routes/app/+layout.ts 0% 0% 0% 0% 1-18
src/routes/app/sidebar/AddOns.svelte 0% 0% 0% 0% 1-35
src/routes/app/sidebar/Documents.svelte 0% 0% 0% 0% 1-63
src/routes/documents/[id]-[slug]/+layout.ts 0% 0% 0% 0% 1-39
Generated in workflow #36

@allanlasser allanlasser added this to the SvelteKit milestone Apr 17, 2024
Debug

Debug

Debug

Fix breadcrumb trail

Breadcrumbs

Cleanup breadcrumb generation with a util fn

Update document breadcrumb href

Reorganize breadcrumbs
@allanlasser allanlasser force-pushed the sveltekit-navigation branch from 0a75bb7 to c0511d2 Compare April 17, 2024 14:34
@allanlasser allanlasser requested a review from eyeseast April 17, 2024 17:33
@allanlasser allanlasser merged commit a59e49d into sveltekit Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants