Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite scroll for search results #494

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Mar 28, 2024

Implements infinite scroll instead of pagination for search results.

Implements "select all" in the manager and shows result counts in the bottom action bar.

Try it here: https://deploy-preview-494.muckcloud.com/app/?q=boston

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 8ccae4f
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/660ad934f55c270008fbfd8f
😎 Deploy Preview https://deploy-preview-494.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyeseast eyeseast marked this pull request as ready for review March 29, 2024 15:53
@eyeseast eyeseast requested a review from allanlasser March 29, 2024 15:53
Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked out the new Storybooks yet, and overall this is looking great! Exporting the state from the list is a good move, keeps everything very easy to reason about.

src/lib/api/types.d.ts Show resolved Hide resolved
src/routes/app/+page.ts Outdated Show resolved Hide resolved
src/routes/app/+page.ts Outdated Show resolved Hide resolved
src/style/kit.css Show resolved Hide resolved
src/lib/components/documents/ResultsList.svelte Outdated Show resolved Hide resolved
src/routes/app/+page.svelte Show resolved Hide resolved
src/routes/app/+page.svelte Show resolved Hide resolved
src/lib/components/documents/ResultsList.svelte Outdated Show resolved Hide resolved
src/routes/app/+page.svelte Show resolved Hide resolved
@eyeseast eyeseast merged commit 473f0cf into sveltekit Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants