-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sveltekit upload #476
Sveltekit upload #476
Conversation
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…d into sveltekit-upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew, big review! Overall looks great, I'm gonna jump into the branch to add a little extra styling and write some tests. I expect this should be in shape to merge Monday.
Co-authored-by: Allan Lasser <[email protected]>
Refactors `$page.data` state into props passed from `+page.svelte` for greater isolation and data decoupling.
…frontend into sveltekit-upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last piece of feedback on the documents.test.ts
. I think asserting that fetch
is called correctly is critical to the validity of the function.
Closes #464
Closes #506
Closes #482
Backend methods:
Frontend:
+page.server.ts
+page.svelte
form
property to handle success or error statesTests and demos: