Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private project editing form #474

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Mar 20, 2024

This resolves an issue where project visibility data is not correctly loaded into the editing form in the ProjectDialog. The project's private value was not exposed on the structure/project object, leading to it being undefined in state.

This fixes the issue by adding a private property onto the Project structure.

For review

  1. In the preview deployment, browse projects and create or edit a public project.
  2. The "Private" checkbox should be unselected.
  3. Select it, then save changes.
  4. The project list should refresh with the new private state. Edit the project again.
  5. The "Private" checkbox should be selected.
  6. Unselect it, then save changes.
  7. The project list should refresh with the new public state.

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 9de04b8
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/65faf9497b30ea000723a394
😎 Deploy Preview https://deploy-preview-474.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 20, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
2.8% (-0% 🔻)
1978/70726
🔴 Branches 3.04% 925/30446
🔴 Functions
3.21% (-0% 🔻)
503/15678
🔴 Lines
2.84% (-0% 🔻)
1796/63215

Test suite run success

84 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 9de04b8

@allanlasser allanlasser force-pushed the 468-private-project-toggle branch from f3ca86b to 9de04b8 Compare March 20, 2024 14:57
@allanlasser allanlasser marked this pull request as ready for review March 20, 2024 14:58
@duckduckgrayduck
Copy link
Contributor

It works!

@allanlasser allanlasser merged commit 4c4fac6 into master Mar 20, 2024
13 checks passed
@allanlasser allanlasser deleted the 468-private-project-toggle branch April 24, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing a project to private seems to be irreversible from the front-end
2 participants