Don't refetch pinned project list more than we need to #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
Test suite run success84 tests passing in 16 suites. Report generated by 🧪jest coverage report action from db1418d |
allanlasser
approved these changes
Mar 19, 2024
| @@ -36,9 +36,6 @@ | |||
| if (!equal($pinStore, pinned)) $pinStore = sortPins(pinned); | |||
There was a problem hiding this comment.
This line was supposed to prevent the update loop, but it clearly wasn't.
There was a problem hiding this comment.
Equality is as hard to check as it is to achieve.
There was a problem hiding this comment.
I think the computed value was the issue, though. It told svelte to set the store value every time the store value changed, so it was always behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computed property was causing a recurring fetch.