-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds document count to ActionBar #470
Conversation
This refactors the ActionBar into a presentational component with an accompanying ActionBarContainer to connect it with our stores. It also adds a Storybook for the component.
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
Show new covered files 🐣
Test suite run success84 tests passing in 16 suites. Report generated by 🧪jest coverage report action from 999b84a |
For some reason, I'm not seeing the action bar at all. No pagination, no menus. |
How do I do that? Right now the preview is missing the menu and paginator entirely. |
Looks like the loading value is not updating correctly, fixed that. To view the Storybook, you can click "Details" on the "UI Tests" CI check. |
This closes #465 by adding a document count back to the ActionBar.
In the process of updating the component, I decoupled it from state with an itermediate ActionBarContainer.
I also updated some styling and created a Storybook for testing.
To review, please approve the new components in our Chromatic Storybook and examine the preview deployment for correct look and behavior.