Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds document count to ActionBar #470

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Adds document count to ActionBar #470

merged 5 commits into from
Mar 19, 2024

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Mar 19, 2024

This closes #465 by adding a document count back to the ActionBar.

In the process of updating the component, I decoupled it from state with an itermediate ActionBarContainer.

I also updated some styling and created a Storybook for testing.

To review, please approve the new components in our Chromatic Storybook and examine the preview deployment for correct look and behavior.

This refactors the ActionBar into a presentational component with an accompanying ActionBarContainer to connect it with our stores. It also adds a Storybook for the component.
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 999b84a
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/65f9d0c6898d3100085dee3b
😎 Deploy Preview https://deploy-preview-470.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
2.8% (-0.01% 🔻)
1978/70729
🔴 Branches
3.04% (-0.01% 🔻)
925/30448
🔴 Functions
3.21% (-0.02% 🔻)
503/15678
🔴 Lines
2.84% (-0.01% 🔻)
1796/63217
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / ActionBarContainer.svelte
0% 0% 0% 0%
🔴
... / ActionBar.stories.svelte
0% 0% 0% 0%

Test suite run success

84 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 999b84a

@eyeseast
Copy link
Collaborator

For some reason, I'm not seeing the action bar at all. No pagination, no menus.

@mitchelljkotler
Copy link
Member

To review, please approve the new components in our Chromatic Storybook and examine the preview deployment for correct look and behavior.

How do I do that? Right now the preview is missing the menu and paginator entirely.

@allanlasser
Copy link
Member Author

To review, please approve the new components in our Chromatic Storybook and examine the preview deployment for correct look and behavior.

How do I do that? Right now the preview is missing the menu and paginator entirely.

Looks like the loading value is not updating correctly, fixed that.

To view the Storybook, you can click "Details" on the "UI Tests" CI check.

@allanlasser allanlasser merged commit 52c866b into master Mar 19, 2024
13 checks passed
@allanlasser allanlasser deleted the document-count branch April 24, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project pinning dropped total document count from pager
3 participants