Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project embeds #467

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Fix project embeds #467

merged 4 commits into from
Mar 12, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Mar 12, 2024

Fix for project embeds. Imports were missing (and maybe always have been).

See it working here: https://deploy-preview-467.muckcloud.com/projects/scotus-200027/

OEmbed does not seem to work on staging, but I believe that's a separate issue.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit f2c2fcc
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/65f0ba74df7bd20008bb1231
😎 Deploy Preview https://deploy-preview-467.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
2.81% (-0% 🔻)
1978/70462
🔴 Branches 3.05% 925/30316
🔴 Functions 3.22% 503/15604
🔴 Lines
2.85% (-0% 🔻)
1796/62986

Test suite run success

84 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from f2c2fcc

@eyeseast eyeseast changed the title Fix import, still getting errors Fix project embeds Mar 12, 2024
@eyeseast eyeseast marked this pull request as ready for review March 12, 2024 20:28
@eyeseast eyeseast merged commit c824aff into master Mar 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants