Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make paginator work with async search results #461

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Mar 4, 2024

Does what it says on the tin.

This has a typescript error in it that's fixed in #460. Not going to touch it here because I don't want to create conflicts.

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 6fe0e4d
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/65e6642674739d000831eaf8
😎 Deploy Preview https://deploy-preview-461.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allanlasser
Copy link
Member

Load doesn't seem to get called when per_page changes—is this intentionally left unimplemented?

@eyeseast
Copy link
Collaborator Author

eyeseast commented Mar 4, 2024

Haven't implemented it yet. Will do that separately. I need to think through how that should work.

Co-authored-by: Allan Lasser <[email protected]>
@eyeseast eyeseast merged commit 5f285a8 into sveltekit Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants