sveltekit components #455
Merged
sveltekit components #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eyeseast
commented
Feb 27, 2024
•
eyeseast
commented
- Button
- Checkbox
- PageToolbar
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
allanlasser
requested changes
Feb 27, 2024
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
The issue is Svue. All the current site components that touch Svue in any way throw errors if Storybook tries to render them using Vite/Rollup. Storybook still works for newer/stateless components, and still deploys, but it's broken in some parts. |
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
allanlasser
reviewed
Feb 28, 2024
allanlasser
requested changes
Feb 28, 2024
allanlasser
requested changes
Feb 28, 2024
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
Co-authored-by: Allan Lasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.