Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for viewer modifications #454

Closed
wants to merge 6 commits into from
Closed

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Feb 23, 2024

  • All existing tests pass
  • Svue removed from src/viewer/modification/modification

⚠️ Not ready to merge. I need to handle reactivity in the class. Currently, selecting thumbnails to modify does not display the modification controls. It could be that I went too far in this PR and need to rollback the de-Svue of modifications.

@allanlasser allanlasser requested a review from eyeseast February 23, 2024 17:04
@allanlasser allanlasser linked an issue Feb 23, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 75ed158
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6601c7d9c2b6d80008679526
😎 Deploy Preview https://deploy-preview-454.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allanlasser allanlasser force-pushed the 443-type-modifications branch from d6fe206 to 120e049 Compare February 23, 2024 17:42
Copy link

github-actions bot commented Feb 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
2.79% (-0.01% 🔻)
1973/70737
🔴 Branches
2.87% (-0.17% 🔻)
873/30386
🔴 Functions
3.17% (-0.04% 🔻)
497/15678
🔴 Lines
2.84% (-0% 🔻)
1795/63226
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / modifySpec.ts
82.06% 77.57% 76.83% 85.17%
🟢
... / modification.ts
76.79% 61.76% 80.56% 81.73%

Test suite run success

84 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 75ed158

@allanlasser allanlasser force-pushed the 443-type-modifications branch from 120e049 to 9c5fe73 Compare March 19, 2024 18:06
@allanlasser allanlasser force-pushed the 443-type-modifications branch from 9c5fe73 to 823018b Compare March 20, 2024 21:05
@eyeseast eyeseast marked this pull request as draft March 21, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs and type definitions for modification spec
1 participant