Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type improvements #423

Merged
merged 17 commits into from
Feb 5, 2024
Merged

Type improvements #423

merged 17 commits into from
Feb 5, 2024

Conversation

allanlasser
Copy link
Member

  • This types some files in src/api:
    • project
    • orgAndUser
  • It updates files that import these and delegates calls to structure fns into managers calling the API.
  • It provides better tooling for checking types with a npm run check command
  • It runs a check job as part of the test GitHub Action.

These changes were made as part of implementing pinned projects and extracted into a standalone branch.

@allanlasser allanlasser requested a review from eyeseast February 1, 2024 17:18
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 17cb9ab
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/65c13af420f87a000889d35e
😎 Deploy Preview https://deploy-preview-423.muckcloud.com/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
2.26% (+0.02% 🔼)
1546/68474
🔴 Branches
2.59% (+0.03% 🔼)
762/29461
🔴 Functions
2.66% (+0.01% 🔼)
403/15133
🔴 Lines
2.26% (+0% 🔼)
1386/61270
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴 api/orgAndUser.ts 0% 0% 0% 0%
🔴 api/project.ts 0% 0% 0% 0%
🔴
... / orgAndUser.ts
0% 0% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / searchParams.js
78.15% (-1.34% 🔻)
72.03%
74.07% (-2.85% 🔻)
83.5% (-1.65% 🔻)

Test suite run success

75 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from 17cb9ab

@allanlasser allanlasser linked an issue Feb 1, 2024 that may be closed by this pull request
@eyeseast eyeseast merged commit f07c675 into master Feb 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type definitions for API responses
2 participants