Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More common components into Storybook #394

Merged
merged 2 commits into from
Dec 18, 2023
Merged

More common components into Storybook #394

merged 2 commits into from
Dec 18, 2023

Conversation

eyeseast
Copy link
Collaborator

This adds four more components into Storybook. These all depend on the router, so my goal is to figure out whether we can make them stateless.

src/common/dialog/SearchTipsDialog.svelte had one Link component, which is now an a tag. It still relies on the orgsAndUsers store in order to check if the current user is logged in, and use that to write an example search.

src/common/ErrorData.svelte uses the nav helper to turn route names into URLs.

src/common/Logo.svelte has a surprising amount of logic in it. This should really just be an icon that gets wrapped in a link, and that logic should be outside the component.

src/common/HtmlField.svelte gets used in the viewer, as text entry. Will probably make a new version in SvelteKit when we have more form handling options.

src/common/Dropdown.svelte should just get replaced with src/common/Dropdown2.svelte.

@eyeseast eyeseast requested a review from allanlasser December 18, 2023 13:26
Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 2569cde
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/65804ab429259e00095cf163
😎 Deploy Preview https://deploy-preview-394.muckcloud.com/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyeseast eyeseast merged commit aca7b13 into master Dec 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant