More common components into Storybook #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds four more components into Storybook. These all depend on the router, so my goal is to figure out whether we can make them stateless.
src/common/dialog/SearchTipsDialog.svelte
had oneLink
component, which is now ana
tag. It still relies on theorgsAndUsers
store in order to check if the current user is logged in, and use that to write an example search.src/common/ErrorData.svelte
uses thenav
helper to turn route names into URLs.src/common/Logo.svelte
has a surprising amount of logic in it. This should really just be an icon that gets wrapped in a link, and that logic should be outside the component.src/common/HtmlField.svelte
gets used in the viewer, as text entry. Will probably make a new version in SvelteKit when we have more form handling options.src/common/Dropdown.svelte
should just get replaced withsrc/common/Dropdown2.svelte
.