Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stories for search bar #377

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Add stories for search bar #377

merged 4 commits into from
Dec 13, 2023

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Dec 12, 2023

Basic search bar stories, now with mocked data.

Closes #369

@eyeseast eyeseast requested a review from allanlasser December 12, 2023 21:35
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 26f3452
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6578ff41f6affb0008596994
😎 Deploy Preview https://deploy-preview-377.muckcloud.com/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/pages/app/stories/SearchBar.stories.svelte Outdated Show resolved Hide resolved
args={{ search: "project:example-project-123" }}
parameters={{
msw: {
handlers: [mock.users.data, mock.organizations.data, mock.projects.data],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User and organization mocking is working as expected, but typing project: doesn't trigger any network requests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to also be an issue in production, so let's consider it a bug to be fixed.

Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data mocking is great, caught two small things

@eyeseast eyeseast merged commit 383b6bb into master Dec 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search bar components to Storybook
2 participants