Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Chromatic #356

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Adds Chromatic #356

merged 2 commits into from
Nov 29, 2023

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Nov 29, 2023

This PR adds a GitHub Action to automatically build and deploy our Storybooks with Chromatic, "a visual testing & review tool" from the creators of Storybook. The Action is powered by an environment secret configured in the GitHub repo.

This provides additional checks on our PRs to ensure that components don't break as code changes, and any intentional changes to components are explicitly accepted by authors/reviewers. This leverages the existing work we've done in developing code within Storybooks to enhance the stability of the frontend codebase.

Use GitHub to log into Chromatic and it should preserve your status as an organization contributor.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 177b048
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/656796e71d29b600082def56
😎 Deploy Preview https://deploy-preview-356.muckcloud.com/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allanlasser allanlasser requested a review from eyeseast November 29, 2023 20:25
@allanlasser allanlasser merged commit fee57e5 into master Nov 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants