Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook updates and fixes #355

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Storybook updates and fixes #355

merged 4 commits into from
Dec 7, 2023

Conversation

allanlasser
Copy link
Member

Now that we're using Svelte 4, we're able to update our Storybook files for improved compatability:

  1. Removes *.demo.svelte components since component composition is working again with @storybook/addon-svelte-csf^4
  2. Replaces deprecated <Meta /> tag with meta object export.
  3. Upgrades Storybook and related packages to most recent versions.

@allanlasser allanlasser requested a review from eyeseast November 29, 2023 19:15
Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit a587fb0
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6570e8c93f85910008ae7aa5
😎 Deploy Preview https://deploy-preview-355.muckcloud.com/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allanlasser
Copy link
Member Author

I'm glad I introduced Chromatic, since it almost immediately caught an issue where the updated version of Storybook causes some of the data loading stories to stop working 🙃

I'll move this PR to Draft status while I investigate further.

@allanlasser allanlasser marked this pull request as draft November 29, 2023 20:41
Since we updated to Svelte4 and the newest version of `@storybook/addon-svelte-csf`, we no longer have to avoid composed components in our stories.
@allanlasser allanlasser marked this pull request as ready for review December 6, 2023 21:33
@allanlasser
Copy link
Member Author

I was able to address the issues with Storybook rendering. I've also confirmed that these changes work fine when rebased on the WIP Vite branch!

@allanlasser allanlasser merged commit e3f7865 into master Dec 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants