Fix more embed types. Ignore TS errors on code we're not keeping.

MuckRock · Apr 16, 2024 · ededd32 · ededd32
1 parent 45ccbfb
commit ededd32
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 14 deletions.
diff --git a/src/api/session.js b/src/api/session.js
@@ -86,6 +86,7 @@ export class SessionCache {
 
 const sessionCache = new SessionCache();
 
+// @ts-ignore
 session.getStatic = async function getStatic(url) {
   if (sessionCache.has(url)) {
     return sessionCache.lookup(url);

diff --git a/src/api/viewer.js b/src/api/viewer.js
@@ -12,6 +12,7 @@ export function documentDimensionUrl(document) {
 function getDesiredSize(desiredWidth) {
   for (let i = 0; i < IMAGE_WIDTHS.length; i++) {
     const [width, name] = IMAGE_WIDTHS[i];
+    // @ts-ignore
     if (desiredWidth <= width) return name;
   }
   return IMAGE_WIDTHS[IMAGE_WIDTHS.length - 1][1];

diff --git a/src/lib/api/addons.ts b/src/lib/api/addons.ts
@@ -1,8 +1,10 @@
+import type { Page } from "@/api/types/common";
+import type { AddOnListItem } from "@/addons/types";
+
 import { error } from "@sveltejs/kit";
+
 import { BASE_API_URL } from "@/config/config.js";
-import { type AddOnListItem } from "@/addons/types";
 import { isErrorCode } from "../utils";
-import type { Page } from "@/api/types/common";
 
 export async function getPinnedAddons(
   fetch = globalThis.fetch,
@@ -15,7 +17,7 @@ export async function getPinnedAddons(
   if (isErrorCode(resp.status)) {
     error(resp.status, resp.statusText);
   }
-  return resp.json();
+  return resp.json() as Promise<Page<AddOnListItem>>;
 }
 
 export async function getAddons(
@@ -26,5 +28,5 @@ export async function getAddons(
   if (isErrorCode(resp.status)) {
     error(resp.status, resp.statusText);
   }
-  return resp.json();
+  return resp.json() as Promise<Page<AddOnListItem>>;
 }
diff --git a/src/routes/(embed)/documents/[id]/pages/[page]/+page.svelte b/src/routes/(embed)/documents/[id]/pages/[page]/+page.svelte
@@ -1,4 +1,5 @@
-<script>
+<script lang="ts">
+  import { createEventDispatcher } from "svelte";
   import { _ } from "svelte-i18n";
 
   import Annotation from "./Annotation.svelte";
@@ -18,6 +19,8 @@
 
   export let data;
 
+  const dispatch = createEventDispatcher();
+
   let elem;
   let active = null;
 

diff --git a/src/routes/(embed)/projects/[project_id]/+page.svelte b/src/routes/(embed)/projects/[project_id]/+page.svelte
@@ -1,4 +1,5 @@
-<script>
+<script lang="ts">
+  import type { Document } from "$lib/api/types";
   import DocumentListItem from "$lib/components/documents/DocumentListItem.svelte";
   import Paginator from "$lib/components/common/Paginator.svelte";
 
@@ -11,17 +12,17 @@
   $: count = data.documents.count;
   $: next = data.documents.next;
   $: previous = data.documents.previous;
-  $: documents = data.documents.results.map((d) => d.document);
+  $: documents = data.documents.results.map((d) => d.document) as Document[];
   $: total_pages = Math.ceil(count / per_page);
 
   async function load(url) {
-    const res = await fetch(url, { credentials: "include" }).catch((e) => ({
-      ok: false,
-      error: e,
-    }));
+    const res = await fetch(url, { credentials: "include" }).catch((e) => {
+      console.error(e);
+      return { ok: false, json: () => {} };
+    });
 
     if (!res.ok) {
-      console.error(res.error);
+      return;
     }
 
     data.documents = await res.json();

diff --git a/src/routes/app/sidebar/AddOns.svelte b/src/routes/app/sidebar/AddOns.svelte
@@ -1,7 +1,9 @@
 <script lang="ts">
+  import type { Page } from "@/api/types/common";
+  import type { AddOnListItem } from "@/addons/types";
+
   import { Book16, Hourglass24, Pin24, Plug16 } from "svelte-octicons";
-  import type { Page } from "@/api/types";
-  import type { AddOnListItem } from "$lib/api/types";
+
   import Action from "$lib/components/common/Action.svelte";
   import Empty from "$lib/components/common/Empty.svelte";
   import Flex from "$lib/components/common/Flex.svelte";