do not use batch route for updating document revision

MuckRock · Jan 10, 2024 · cbc27b9 · cbc27b9
1 parent 038cadb
commit cbc27b9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 19 deletions.
diff --git a/src/api/document.js b/src/api/document.js
@@ -161,18 +161,15 @@ export async function changeAccess(ids, access) {
   );
 }
 
-export async function changeRevisionControl(ids, revision_control) {
-  // Enable or disable revision control on specified documents
+export async function changeRevisionControl(id, revision_control) {
+  // Enable or disable revision control on specified document
   const { data } = await session.patch(
     apiUrl(
-      queryBuilder(`documents/`, {
+      queryBuilder(`documents/${id}/`, {
         expand: [DEFAULT_EXPAND, "revisions"].join(","),
       }),
     ),
-    ids.map((id) => ({
-      id,
-      revision_control,
-    })),
+    {revision_control}
   );
   return data;
 }

diff --git a/src/common/dialog/RevisionsDialogContainer.svelte b/src/common/dialog/RevisionsDialogContainer.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-  import { changeRevisionControlForDocuments } from "../../manager/documents";
+  import { changeRevisionControlForDocument } from "../../manager/documents";
   import { viewer } from "../../viewer/viewer.js";
   import RevisionsDialog from "./RevisionsDialog.svelte";
   import emitter from "../../emit.js";
@@ -13,7 +13,7 @@
   const revisions = document?.revisions;
   const enabled = document?.revisionControl;
   const onSave = async (enabled: boolean) => {
-    await changeRevisionControlForDocuments([document], enabled);
+    await changeRevisionControlForDocument(document, enabled);
     emit.dismiss();
   };
   const onCancel = () => {

diff --git a/src/manager/documents.js b/src/manager/documents.js
@@ -434,22 +434,20 @@ export async function changeAccessForDocuments(
   hideAccess();
 }
 
-export async function changeRevisionControlForDocuments(
-  documents,
+export async function changeRevisionControlForDocument(
+  document,
   revision_control,
 ) {
   await wrapLoad(layout, async () => {
     await changeRevisionControl(
-      documents.map((doc) => doc.id),
+      document.id,
       revision_control,
     );
-    documents.forEach((doc) => {
-      updateInCollection(doc, (d) => {
-        d.doc = {
-          ...d.doc,
-          revision_control,
-        };
-      });
+    updateInCollection(document, (d) => {
+      d.doc = {
+        ...d.doc,
+        revision_control,
+      };
     });
   });
   hideRevisions();