Catch invalid selector in FlatPage.svelte

MuckRock · Nov 20, 2023 · c5d1103 · c5d1103
1 parent eb4ae50
commit c5d1103
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/src/addons/dispatch/Selection.svelte b/src/addons/dispatch/Selection.svelte
@@ -92,7 +92,7 @@
           bind:group={choice}
         />
         {$_("addonDispatchDialog.labelSelected", {
-          values: { n: $layout.selected.length },
+          values: { n: $layout.selected?.length },
         })}
       </label>
     {/if}

diff --git a/src/addons/dispatch/fields/ArrayField.svelte b/src/addons/dispatch/fields/ArrayField.svelte
@@ -15,8 +15,8 @@
   };
 
   export let count: number = 1;
-
   export let value = Array(count).fill(null);
+
   $: numItems = value.length;
 
   // only one level of nesting allowed

diff --git a/src/api/document.js b/src/api/document.js
@@ -73,7 +73,7 @@ export async function searchDocumentsUrl(url) {
 
 async function searchDocumentsHelper(url) {
   const { data } = await session.get(url);
-  if (data.results.length > 0 && data.results[0].hasOwnProperty("document")) {
+  if (data.results?.length > 0 && data.results[0].hasOwnProperty("document")) {
     // if we are using the project API, the document is one level down
     data.results = filterDeleted(
       data.results.map((doc) => new Document(doc.document)),
@@ -112,7 +112,7 @@ export async function getDocumentsWithIds(
     GET_BATCH,
     GET_BATCH_DELAY,
     async (subIds) => {
-      if (subIds.length == 0) return [];
+      if (subIds?.length == 0) return [];
       // Return documents with the specified ids
       const params = { expand, id__in: subIds };
       if (remaining) params["remaining"] = true;

diff --git a/src/pages/FlatPage.svelte b/src/pages/FlatPage.svelte
@@ -26,7 +26,13 @@
   }
 
   function navTo(hash, smooth = false) {
-    const elem = document.querySelector(hash);
+    let elem;
+    try {
+      elem = document.querySelector(hash);
+    } catch (error) {
+      elem = null;
+    }
+
     if (elem) {
       if (elem.scrollIntoView) {
         elem.scrollIntoView({

diff --git a/tests/README.md b/tests/README.md
@@ -6,4 +6,4 @@ This directory includes [Playwright](https://playwright.dev) tests that run in a
 URL=https://www.dev.documentcloud.org npx playwright test
 ```
 
-Netlify will automatically run this against any pull request using a deploy preview, and it will set the `URL` environment variable to the correct target.
+Github will automatically run this against any pull request using a deploy preview, and it will set the `URL` environment variable to the correct target.