Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScribbleArea repaint when tiled buffer does not cover update rect #21

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix ScribbleArea repaint when tiled buffer does not cover update rect #21

merged 1 commit into from
Sep 18, 2023

Conversation

J5lx
Copy link

@J5lx J5lx commented Sep 17, 2023

No description provided.

@J5lx J5lx mentioned this pull request Sep 17, 2023
Merged
@MrStevns
Copy link
Owner

I did some debugging and managed to fix the issue with Alt and the cursor leaving ScribbleArea. It was caused by CanvasPainter::paintCurrentBitmapFrame assuming that the tiled buffer covered the entire blit rect, which isn’t necessarily the case.

Fair point, changes looks good to me. Thanks!

@MrStevns MrStevns merged commit e79a399 into MrStevns:painting-blitting-improvements-v2 Sep 18, 2023
7 checks passed
@J5lx J5lx deleted the MrStevns/painting-blitting-improvements-v2 branch September 22, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J5lx @MrStevns