-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test over multiple python versions #118
base: main
Are you sure you want to change the base?
Conversation
I've been running the tests on my fork and it appears that python 3.11 may cause some problems - I'll remove that for the time being. https://github.com/ianwesleyarmstrong/mack/actions/runs/5652132175 |
How does this deal with the Delta Lake / PySpark versions that are incompatible? I don't think mack supports Delta 1.0. Here are the version combinations I think we should run (Delta Lake version | PySpark version): 2.4.x | 3.4.x This comes from the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (and just learnt that mack uses poetry 👏👏👏 )
Hi @MrPowers, Is there any updates on this branch? I'm looking forward to using mack on pyspark 3.4.1 and delta-spark 2.4.0. |
I started with the currently supported python versions and any minor versions of delta lake > 1.0 - I'm happy to adjust these as needed. I thought it also might be worthwhile to test over different versions of
pyspark
, so I included the minor versions > 3 as well: