Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localnode has been repaired #634

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

Blacklist897
Copy link
Contributor

@Blacklist897 Blacklist897 commented Dec 21, 2024

With oswalds apparent death, localnode has convinced shrike to allow it to merge with the lavaland orbit fragment

(better desc, updated sprites)

CHECK LIST

  1. If you're adding new code... Make sure it compiles and is tested. Any changes made to /tg/station files should either be modularized out if possible, or otherwise have // NON-MODULE CHANGE appended.
  2. If you're adding sounds or sprites... Including a picture of the new sprites or clips of new sounds is more than appreciated. If you've modified /tg/station DMI icons, either move them to our modules subfolder or accept they will be overridden next update.
  3. If you're mapping... Including screenshots of changes is preferred. Avoid editing /tg/station map files unless you are okay with them being overridden next update.
  4. Make sure that any changes to /tg/station files are appended with // NON-MODULE CHANGE!
  5. If you have any other questions on how to modularize certain aspects, ask. Some things are impossible to split out, like GAGS configs, string files, and TGUI interfaces, so just ensure it's easy to tell modular files apart.
  6. Optionally, providing a unit test with your feature is an excellent way to ensure it is not broken come next merge.

MODULARITY

It's important to ALWAYS MAKE SURE to modularize your content! If you need to touch the main game files, ALWAYS use "NON-MODULE" in the comment.
Multi line changes should have "NON-MODULE START / END" to denote the multi line changes, if applicable in succession.
Images added to master .dmi files will be rejected and you will be asked to modularize them, even if you need to copy the master file.
image

With oswalds apparent death, localnode has convinced shrike to allow it to merge with the lavaland orbit fragment

(better desc, updated sprites)
@MrMelbert MrMelbert merged commit 06ad29c into MrMelbert:master Dec 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants