Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB Ignore] [IDB Ignore] Nebula Station, or, cherry picks a bunch of PRs so I can cherry pick Nebula Station (Also removes Birdboat) [MDB IGNORE] [IDB IGNORE] #623

Merged
merged 58 commits into from
Nov 26, 2024

Conversation

MrMelbert
Copy link
Owner

@MrMelbert MrMelbert commented Nov 19, 2024

Ports:

  • Nebulastation

Deletes:

  • Birdboat Station

Also cherry picks:

  • Dehydrator
  • Show drains
  • Table mounted keycard auths
  • Mobile defib mounts
  • Telescreen dirs
  • Detective Board
  • Photobooth
  • Scanner gates
  • Curator camera
  • Flippable sec helmets
  • Cyto vendor
  • Some new masks (also in loadout)

Notable missing prs:

  • Arcmining stuff
  • Flatpacker
  • Vat grower
  • Cigarette repath

KikoWen0 and others added 30 commits November 19, 2024 14:08
Adds a completely brand new multi-z station map "NebulaStation".
New areas and few exclusive map shuttles (ferry, mining, arrival, evac,
cargo)
## About The Pull Request

Turns the varedited fluff item into its own item so it no longer has a
varedited icon & icon state.

## Why It's Good For The Game

We're varediting this fluff item 17 times on current tg master and it's
pretty bad. Varediting icon/icon state in maps should be discouraged and
hopefully banned later, it's not hard to make a subtype of an item so we
should be able to expect mappers to do that rather than this.

## Changelog

Nothing player-facing.
We have an ID authorisation panel machine used for things like red
alert, where you need to swipe a card in two different places to
validate it.
_Normally_ this is mounted on a wall in an office, but sometimes it is
on a table. We use the same machine code and sprite for both,

Also as a result of doing this, I've made wallmounted ID card auth
devices _actually_ attach to the wall in terms of "If the wall goes,
they go too". This may or may not be a good idea given that as far as I
can tell they aren't constructible (and probably shouldn't be given that
then you'd just activate both with one ID card all the time) but seems
broadly sensible to me?
## About The Pull Request


![image](https://github.com/tgstation/tgstation/assets/70376633/e8650bc6-e915-499c-8a63-eba0a70b4a96)

![image](https://github.com/tgstation/tgstation/assets/70376633/14a95345-e436-43c7-b4a7-de2502fc59cc)


5 iron and 1 sheet of silver and 15 cable to craft

its a defib mount but mobile, thats basically it

## Why It's Good For The Game

good for maps where there are no good spots to place wall defib mounts
or if you cant or dont want to take off your backpack (maybe using a
modsuit?) and theres no defib mount nearby


## Changelog
:cl:
add: mobile defibrillator mount
/:cl:
## About The Pull Request

Adds a corner version of the filled/warning decal.


![image](https://github.com/tgstation/tgstation/assets/102194057/24a57e6e-53b8-4a72-8ef3-b9c76205ef69)
## Why It's Good For The Game

The filled/warning decal is pretty and I wished it were easier to use in
more places but without a corner sprite corners can look weird with it
## Changelog
:cl:
add: Added corner filled warning decals
/:cl:
## About The Pull Request

If you switch case, the ropes will stay, untill you reenter in the
interface. Now it will change to new case's ropes ☑
If you scroll down with linked evidences, ropes will stay on the screen.
Now it will move with evidences ☑
If you try put big content in paper, evidence wil be VERY big. Now max
width is 300px ☑
Title will wrap, if it too big. Content of evidence too. ☑

Also i again fixed placement problem, because of wallening revert ☑

## Why It's Good For The Game

Fixes

## Changelog

:cl: FeudeyTF
fix: fixed an UI problems of evidence board
/:cl:
## About The Pull Request

If you remove last case, board will crash. Now will not.
Also i limited number of cases for 8 cases

## Why It's Good For The Game

Fixes

## Changelog
:cl: FeudeyTF
fix: fixed removing last case
/:cl:
## About The Pull Request

Closes #87418
Also fixes an issue where scanlines are A) not present until someone
walks through them B) don't disappear when the gate is unpowered

## Changelog
:cl:
qol: Made scanner gate scanlines mouse transparent
fix: Scanner gate scanlines no longer appear only after someone walks
through them and are disabled when the gate is unpowered
/:cl:
MrMelbert and others added 14 commits November 19, 2024 16:27
## About The Pull Request
Adds 3 new masks:
* Kitsune mask
* Facescarf
* Rebellion mask
All masks (and facescarf) are recolorable. And also thanks to Kovac for
the scarf sprites
## Why It's Good For The Game
Cool masks for make character style more unique. All are recolourable.

![2024-01-28_12-20-48](https://github.com/tgstation/tgstation/assets/106491639/49b532f7-ccfe-4556-a54f-a4884a9fda77)

## Changelog
:cl:
add: 3 new masks for your characters (thanks to Kovac for the scarf
sprites)
/:cl:

---------

Co-authored-by: tattle <[email protected]>
## About The Pull Request

During the feature freeze someone pointed out that it was weird that
mothic rations can get dirty if dropped on the floor, as they're
supposed to be inside wrappers.
I added a trash type to them, which has the added side-effect of the
game assuming that if it leaves trash it probably doesn't get dirty when
dropped on the ground.

I also changed the colour of the text on the wrapper from black to very
very dark brown because I didn't like drawing it in black on the
wrapper.

## Why It's Good For The Game

More immersive. More Janitor content.

## Changelog

:cl:
add: Mothic Fleet Rations now no longer get dirty or decompose if left
on the floor, due to their wrappers.
/:cl:
## About The Pull Request
Resprites the kitsune mask, making it so it looks more foxy and fixing
some consistency issues with the mob sprite such as the addition of the
top stripe while making the color scheme consistent with other GAGS
items.
Kitsune masks are also now adjustable by using them in-hand

![image](https://github.com/user-attachments/assets/fb01fc38-7434-4e87-9cbc-8ed4edbc5633)

![dreamseeker_VQKSlC8mM8](https://github.com/user-attachments/assets/40681ca8-d949-4b4d-afe9-f3ac64ad676e)

![dreamseeker_9hDiKmeBzY](https://github.com/user-attachments/assets/ffe5f28c-7368-4552-9f13-7e2b622582b5)



## Why It's Good For The Game
Makes the mask look cleaner, consistent and better looking while giving
players an option to adjust the mask at will, allowing for more
customization options.


## Changelog
:cl: Hardly
image: Resprited kitsune masks
image: Kitsune masks are now adjustable. Use it in-hand!
/:cl:
@MrMelbert MrMelbert added Map Oh christ what have you done Cherry Picked We're behind on schedule; and this is something we fucking need labels Nov 19, 2024
@MrMelbert MrMelbert changed the title [MDB Ignore] [IDB Ignore] Nebula Station, or, cherry picks a bunch of PRs so I can cherry pick Nebula Station [MDB IGNORE] [IDB IGNORE] [MDB Ignore] [IDB Ignore] Nebula Station, or, cherry picks a bunch of PRs so I can cherry pick Nebula Station (Also removes Birdboat) [MDB IGNORE] [IDB IGNORE] Nov 20, 2024
@MrMelbert MrMelbert marked this pull request as ready for review November 24, 2024 20:22
@github-actions github-actions bot added the Merge Conflict Resolve it or perish label Nov 24, 2024
@MrMelbert MrMelbert merged commit b1ea014 into master Nov 26, 2024
21 checks passed
@MrMelbert MrMelbert deleted the nebula branch November 26, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cherry Picked We're behind on schedule; and this is something we fucking need Map Oh christ what have you done Merge Conflict Resolve it or perish
Projects
None yet
Development

Successfully merging this pull request may close these issues.