Bunch of examine + health analyzer updates + Allows you to examine / point at items worn by others #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request I tested these in every single iteration but the final one. So it was doing `string + list()` and runtiming because it lost a `. = list()` ## Changelog :cl: Melbert fix: Med/sec hud examine /:cl:
## About The Pull Request The screen alert for being wounded is deleted Instead, your health doll will now glow red on any (and all) wounded limbs https://github.com/user-attachments/assets/83565684-3e19-4753-8034-d8de6574e2b8 To accomplish this, the doll was refactored a bit. No longer operates off of overlays, now uses vis contents across every limb, and just updates the icon state of all those vis contents ## Why It's Good For The Game Wounds really spam the hell out of you with screen alerts and it often blocks you from seeing more relevant alerts that you care about The mere presence of a minor dislocation on your leg prevents you from noticing that you are no longer breathing. This is a bit troublesome This can be resolved in other ways, of course - adding a priority value to alerts? - but instead, I think we can just make better use of our existing hud elements I find this decently intuitive, at a glance. - The old screen alert gave you a tooltip saying you could click the alert to examine yourself. - Clicking on the health doll examines yourself the exact same way. - So, players may see their doll glowing red, and click on it to self examine, to see the report of them having a wound on their leg or chest or whatever. ## Changelog :cl: Melbert del: Having any wounds no longer gives you an alert in the top right qol: Having any wounds now make the corresponding bodypart on your health doll (the lil dude on the right side of the screen) glow red. refactor: Refactored how the hud's health doll shows up for humans. Report any oddities /:cl:
## About The Pull Request Advanced health analyzers have an intended ling check which tells you if the scanned body is faking death (is in regen stasis), which is at odds with the rest of the codebase (which actively removes unintentional ling checks and blocks the addition of intentional ones). This PR removes it (making advanced analyzers unable to determine if the target is faking death). Also tweaks some code around it in general. ## Why It's Good For The Game I'm actually like 50/50 on whether this should actually be removed or not, so I opened the PR for discussion. On one hand I think it's kind of interesting to have a doctor look at the results *closely* and realize something is wrong here. On the other hand, ling check bad? ## Changelog :cl: Melbert del: Advanced Health Analyzers can no longer be used to determine if a body is faking death (like a changeling) /:cl:
MrMelbert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports a bunch of PRs
Examining a mob wearing clothing allows you to examine the clothing by clicking on them in chat
Examining an item via the above method allows you to click on the item's name in chat to point at it, allowing you to specifically
"points at John Doe's yellow jumpsuit".