Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sunscreen #570

Merged
merged 30 commits into from
Sep 1, 2024
Merged

Adds sunscreen #570

merged 30 commits into from
Sep 1, 2024

Conversation

Constellado
Copy link
Contributor

@Constellado Constellado commented Aug 25, 2024

What is this?

This adds sunscreen to the game! This PR was made for the upcoming beach episode. I have made a Nanotrasen, Generic and Volkan's sunscreen.

image

When you apply it, it adds a burn resistance based on its SPF rating! If its SPF rating is 50, it will add 5% burn resistance to the player.

Why does Volkan have his own sunscreen?

Volkan tends to have his own stuff made at his station, and it is almost always in a metal container. This sunscreen is also spray based to speed up application.
Volkan and his synthetic avatar is sensitive to the sun so it had to be made. He will be using this a bunch at the beach, that is for sure.

@Constellado
Copy link
Contributor Author

Oh my god vscode decided to untick it right before I went to sleep.

///how long it takes to apply in seconds
var/application_time = 10 SECONDS
///How long it takes before sunscreen runs out in seconds
var/reaplication_time = 1800 SECONDS
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to change it but keep in mind you can just as easily write 30 MINUTES (and it's a fair bit easier to see at a glance)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, if I had it in minutes the status affect would still treat it like seconds?
Thats why I changed it to seconds. Maybe it was some one time fluke or something strange but I don't want to touch it now because of that.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 MINUTES is identical to 1800 SECONDS 🤔

@MrMelbert MrMelbert merged commit 8218306 into MrMelbert:master Sep 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants